Skip to content

Default initialize class_hierarchy #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2019
Merged

Default initialize class_hierarchy #4876

merged 1 commit into from
Jul 8, 2019

Conversation

romainbrenguier
Copy link
Contributor

@romainbrenguier romainbrenguier commented Jul 5, 2019 •
edited
Loading

This could prevent compilation in some compiler configurations.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@romainbrenguier romainbrenguier added the Needs TG approval 🦉 Only merge with explicit approval from test-gen maintainers label Jul 5, 2019
allredj
allredj reviewed Jul 5, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 2568e40).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/118088141

@codecov-io
Copy link

codecov-io commented Jul 5, 2019 •
edited
Loading

Codecov Report

Merging #4876 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4876   +/-   ##
========================================
  Coverage    69.09%   69.09%           
========================================
  Files         1298     1298           
  Lines       106947   106947           
========================================
  Hits         73896    73896           
  Misses       33051    33051
Impacted Files Coverage Δ
...de/java_bytecode_convert_method/convert_method.cpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8562b28...0cc6f93. Read the comment docs.

@romainbrenguier romainbrenguier force-pushed the bugfix/convert-method-include branch from 2568e40 to 1a1775e Compare July 5, 2019 15:47
@romainbrenguier romainbrenguier changed the title Add missing include Default initialize class_hierarchy Jul 5, 2019
@romainbrenguier
Default initialize class_hierarchy
0cc6f93 
clang++-3.7 will complain if we don't use the user provided default
constructor.
@romainbrenguier romainbrenguier force-pushed the bugfix/convert-method-include branch from 1a1775e to 0cc6f93 Compare July 8, 2019 07:10
allredj
allredj reviewed Jul 8, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 0cc6f93).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/118239674

@allredj allredj mentioned this pull request Jul 8, 2019
Merged
7 tasks
@romainbrenguier romainbrenguier merged commit acb3aba into diffblue:develop Jul 8, 2019
@romainbrenguier romainbrenguier deleted the bugfix/convert-method-include branch July 8, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschrammel peterschrammel peterschrammel approved these changes

@allredj allredj allredj approved these changes

Assignees

@romainbrenguier romainbrenguier

Labels
Needs TG approval 🦉 Only merge with explicit approval from test-gen maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romainbrenguier @codecov-io @peterschrammel @allredj